telmo at MIT.EDU
Fri Jun 6 01:10:09 EDT 2008
Gah. Of course my messages didn't make sense. I hadn't committed the last
version yesterday before falling asleep. My bad.
I fixed constructor handling to be done with r2621 style, ignoring the
receiver, and using a TreePreAnnotator to do it. Not as elegant and
concise on the checker, but that can wait until after the next release.
Sorry about the inconvenience. Every test now passes.
On Thu, 5 Jun 2008, Mahmood Ali wrote:
> Hi Telmo,
> I am leaning towards 'yes'. Since no-one has witnessed the problem you are
> describing, I think it's safe to hold on the fix till the following release
> (hopefully next week). Hopefully, we will have all code review comments
> addressed by then too.
> - Mahmood
> On Jun 5, 2008, at 9:37 PM, Telmo wrote:
>> I am still not sure on how to fix the bugs that the changes to
>> AnnotatedTypeFactory and TypeFromTree introduced. Should I revert them (and
>> JavariAnnotatedFactory) before the release?
>> On Thu, 5 Jun 2008, Mahmood Ali wrote:
>>> Hi Matt,
>>> Do you think that you will have a chance to check-in your ClassReader
>>> code today. I will work on making the release once you check-in your
>>> - Mahmood
>>> checkers mailing list
>>> checkers at lists.csail.mit.edu
More information about the checkers