[Checkers] framework

[Artemus Harper]

A couple of items:
AnnotationUtils.isSame assumes that two annotation are the same if their
toString values are the same. The implementation of AnnotationBuilder's
annotation returns a different string format.

AnnotatedTypeMirror.addAnnotation does not state the behavior if the
annotation to be added already exists, but with different element values.
The current implementation does remove the existing annotation, it is
necessary to manually remove a previous one before adding a new one. For me
the best implementation would be to ask the typeFactory to combine the
annotations, whereas the default implementation would throw an exception if
the values did not match (or possibly a more sophicated implementation that
would attempt to combine array values if possible).

and on the same note

AnnotatedTypeMirror removeAnnotation removes annotations based on the
annotation's type, ignoring any values. The spec is not clear on this.

or

Maybe multiple annotations of the same type on an element is still on the
table?

-- 
Artemus Harper
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.csail.mit.edu/mailman/private/checkers/attachments/20080819/dc68a531/attachment.htm